Commit 99beca13 authored Mar 06, 2015 by Haneen Mohammed Committed by Greg Kroah-Hartman Mar 06, 2015

Staging: gdm72xx: clean dev_err logging



This patch removes  __func__ from dev_err. dev_err includes information about:
(devcice, driver, specific instance of device, etc) in the log printout.
This was done using Coccinelle, with the following semantic patch:

@a@
expression E, R;
expression  msg;
@@

dev_err(E, msg, __func__, R);

@script:python b@
e << a.msg;
y;
@@

if(e.find("%s: ") == True):
	m = e.replace("%s: ", "", 1);
	coccinelle.y = m;
elif(e.find("%s ") == True):
	m = e.replace("%s ", "", 1);
	coccinelle.y = m;
elif(e.find("%s:") == True):
	m = e.replace("%s:", "", 1);
	coccinelle.y = m;
else:
	m = e.replace("%s", "",1);
	coccinelle.y = m;

@c@
expression a.E, a.msg, a.R;
identifier  b.y;
@@

- dev_err(E, msg, __func__, R);
+ dev_err(E, y, R);

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8c6ccbeb

drivers/staging/gdm72xx/gdm_sdio.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -223,8 +223,7 @@ static void send_sdio_pkt(struct sdio_func func, u8 data, int len)
		if (ret < 0) {
		if (ret != -ENOMEDIUM)
		dev_err(&func->dev,
		"gdmwms: %s error: ret = %d\n",
		__func__, ret);
		"gdmwms: error: ret = %d\n", ret);
		goto end_io;
		}
		}
		@@ -237,8 +236,7 @@ static void send_sdio_pkt(struct sdio_func func, u8 data, int len)
		if (ret < 0) {
		if (ret != -ENOMEDIUM)
		dev_err(&func->dev,
		"gdmwms: %s error: ret = %d\n",
		__func__, ret);
		"gdmwms: error: ret = %d\n", ret);
		goto end_io;
		}
		}