Commit 9983028e authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: optimise req->ctx reloads 



Don't load req->ctx in advance, it takes an extra register and the field
stays valid even after opcode handlers. It also optimises out req->ctx
load in io_iopoll_req_issued() once it's inlined.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/1e45ff671c44be0eb904f2e448a211734893fa0b.1634314022.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 607b6fb8

fs/io_uring.c

+1 −2
Original line number Diff line number Diff line
@@ -6588,7 +6588,6 @@ static void io_clean_op(struct io_kiocb *req) 


static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags)

{

	struct io_ring_ctx *ctx = req->ctx;

	const struct cred *creds = NULL;

	int ret;
@@ -6715,7 +6714,7 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags) 
	if (ret)

		return ret;

	/* If the op doesn't have a file, we're not polling for it */

	if ((ctx->flags & IORING_SETUP_IOPOLL) && req->file)

	if ((req->ctx->flags & IORING_SETUP_IOPOLL) && req->file)

		io_iopoll_req_issued(req);



	return 0;