Commit 997e010d authored by Johan Hovold's avatar Johan Hovold Committed by Bjorn Helgaas
Browse files

PCI: qcom: Fix host-init error handling 

Implement the new host_deinit() callback so that the PHY is powered off
and regulators and clocks are disabled also on late host-init errors.

Link: https://lore.kernel.org/r/20221017114705.8277-2-johan+linaro@kernel.org


Fixes: 82a82383 ("PCI: qcom: Add Qualcomm PCIe controller driver")
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
parent 720e0d91

drivers/pci/controller/dwc/pcie-qcom.c

+12 −1
Original line number Diff line number Diff line
@@ -1534,8 +1534,19 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) 
	return ret;

}



static void qcom_pcie_host_deinit(struct dw_pcie_rp *pp)

{

	struct dw_pcie *pci = to_dw_pcie_from_pp(pp);

	struct qcom_pcie *pcie = to_qcom_pcie(pci);



	qcom_ep_reset_assert(pcie);

	phy_power_off(pcie->phy);

	pcie->cfg->ops->deinit(pcie);

}



static const struct dw_pcie_host_ops qcom_pcie_dw_ops = {

	.host_init	= qcom_pcie_host_init,

	.host_deinit	= qcom_pcie_host_deinit,

};



/* Qcom IP rev.: 2.1.0	Synopsys IP rev.: 4.01a */