Commit 981b22b8 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

tty: remove TTY_LDISC_MAGIC 



First, it is never checked. Second, use of it as a debugging aid is
at least questionable. With the current tools, I don't think anyone used
this kind of thing for debugging purposes for years.

On the top of that, e.g. serdev does not set this field of tty_ldisc_ops
at all.

So get rid of this legacy.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210302062214.29627-8-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3b00b6af

Documentation/process/magic-number.rst

+0 −1
Original line number Diff line number Diff line
@@ -88,7 +88,6 @@ TTY_MAGIC 0x5401 tty_struct ``include/linux/ 
MGSL_MAGIC            0x5401           mgsl_info                ``drivers/char/synclink.c``

TTY_DRIVER_MAGIC      0x5402           tty_driver               ``include/linux/tty_driver.h``

MGSLPC_MAGIC          0x5402           mgslpc_info              ``drivers/char/pcmcia/synclink_cs.c``

TTY_LDISC_MAGIC       0x5403           tty_ldisc                ``include/linux/tty_ldisc.h``

USB_SERIAL_MAGIC      0x6702           usb_serial               ``drivers/usb/serial/usb-serial.h``

FULL_DUPLEX_MAGIC     0x6969                                    ``drivers/net/ethernet/dec/tulip/de2104x.c``

USB_BLUETOOTH_MAGIC   0x6d02           usb_bluetooth            ``drivers/usb/class/bluetty.c``

Documentation/translations/it_IT/process/magic-number.rst

+0 −1
Original line number Diff line number Diff line
@@ -94,7 +94,6 @@ TTY_MAGIC 0x5401 tty_struct ``include/linux/ 
MGSL_MAGIC            0x5401           mgsl_info                ``drivers/char/synclink.c``

TTY_DRIVER_MAGIC      0x5402           tty_driver               ``include/linux/tty_driver.h``

MGSLPC_MAGIC          0x5402           mgslpc_info              ``drivers/char/pcmcia/synclink_cs.c``

TTY_LDISC_MAGIC       0x5403           tty_ldisc                ``include/linux/tty_ldisc.h``

USB_SERIAL_MAGIC      0x6702           usb_serial               ``drivers/usb/serial/usb-serial.h``

FULL_DUPLEX_MAGIC     0x6969                                    ``drivers/net/ethernet/dec/tulip/de2104x.c``

USB_BLUETOOTH_MAGIC   0x6d02           usb_bluetooth            ``drivers/usb/class/bluetty.c``

Documentation/translations/zh_CN/process/magic-number.rst

+0 −1
Original line number Diff line number Diff line
@@ -77,7 +77,6 @@ TTY_MAGIC 0x5401 tty_struct ``include/linux/ 
MGSL_MAGIC            0x5401           mgsl_info                ``drivers/char/synclink.c``

TTY_DRIVER_MAGIC      0x5402           tty_driver               ``include/linux/tty_driver.h``

MGSLPC_MAGIC          0x5402           mgslpc_info              ``drivers/char/pcmcia/synclink_cs.c``

TTY_LDISC_MAGIC       0x5403           tty_ldisc                ``include/linux/tty_ldisc.h``

USB_SERIAL_MAGIC      0x6702           usb_serial               ``drivers/usb/serial/usb-serial.h``

FULL_DUPLEX_MAGIC     0x6969                                    ``drivers/net/ethernet/dec/tulip/de2104x.c``

USB_BLUETOOTH_MAGIC   0x6d02           usb_bluetooth            ``drivers/usb/class/bluetty.c``

drivers/accessibility/speakup/spk_ttyio.c

+0 −1
Original line number Diff line number Diff line
@@ -104,7 +104,6 @@ static int spk_ttyio_receive_buf2(struct tty_struct *tty, 


static struct tty_ldisc_ops spk_ttyio_ldisc_ops = {

	.owner          = THIS_MODULE,

	.magic          = TTY_LDISC_MAGIC,

	.name           = "speakup_ldisc",

	.open           = spk_ttyio_ldisc_open,

	.close          = spk_ttyio_ldisc_close,

drivers/bluetooth/hci_ldisc.c

+0 −1
Original line number Diff line number Diff line
@@ -821,7 +821,6 @@ static __poll_t hci_uart_tty_poll(struct tty_struct *tty, 


static struct tty_ldisc_ops hci_uart_ldisc = {

	.owner		= THIS_MODULE,

	.magic		= TTY_LDISC_MAGIC,

	.name		= "n_hci",

	.open		= hci_uart_tty_open,

	.close		= hci_uart_tty_close,