Commit 9736fc04 authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman
Browse files

staging: most: hdm-usb: remove unnecessary status assignment 



The USB completion callbacks set the status field of an MBO object before
scheduling the clear_work. This patch removes this redundant assignment as
the work_struct does the same for all MBOs.

Signed-off-by: default avatarAndrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 089612f1

drivers/staging/most/hdm-usb/hdm_usb.c

+0 −2
Original line number Diff line number Diff line
@@ -412,7 +412,6 @@ static void hdm_write_completion(struct urb *urb) 
			dev_warn(dev, "Broken OUT pipe detected\n");

			mdev->is_channel_healthy[channel] = false;

			spin_unlock_irqrestore(lock, flags);

			mbo->status = MBO_E_INVAL;

			mdev->clear_work[channel].pipe = urb->pipe;

			schedule_work(&mdev->clear_work[channel].ws);

			return;
@@ -570,7 +569,6 @@ static void hdm_read_completion(struct urb *urb) 
			dev_warn(dev, "Broken IN pipe detected\n");

			mdev->is_channel_healthy[channel] = false;

			spin_unlock_irqrestore(lock, flags);

			mbo->status = MBO_E_INVAL;

			mdev->clear_work[channel].pipe = urb->pipe;

			schedule_work(&mdev->clear_work[channel].ws);

			return;