Commit 9568bfb4 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Borislav Petkov
Browse files

x86/fpu: Remove pointless argument from switch_fpu_finish() 



Unused since the FPU switching rework.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20211015011538.433135710@linutronix.de
parent 082f20b2

arch/x86/include/asm/fpu/internal.h

+1 −1
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ static inline void switch_fpu_prepare(struct fpu *old_fpu, int cpu) 
 * Delay loading of the complete FPU state until the return to userland.

 * PKRU is handled separately.

 */

static inline void switch_fpu_finish(struct fpu *new_fpu)

static inline void switch_fpu_finish(void)

{

	if (cpu_feature_enabled(X86_FEATURE_FPU))

		set_thread_flag(TIF_NEED_FPU_LOAD);

arch/x86/kernel/process_32.c

+1 −2
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) 
	struct thread_struct *prev = &prev_p->thread,

			     *next = &next_p->thread;

	struct fpu *prev_fpu = &prev->fpu;

	struct fpu *next_fpu = &next->fpu;

	int cpu = smp_processor_id();



	/* never put a printk in __switch_to... printk() calls wake_up*() indirectly */
@@ -213,7 +212,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) 


	this_cpu_write(current_task, next_p);



	switch_fpu_finish(next_fpu);

	switch_fpu_finish();



	/* Load the Intel cache allocation PQR MSR. */

	resctrl_sched_in();

arch/x86/kernel/process_64.c

+1 −2
Original line number Diff line number Diff line
@@ -559,7 +559,6 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) 
	struct thread_struct *prev = &prev_p->thread;

	struct thread_struct *next = &next_p->thread;

	struct fpu *prev_fpu = &prev->fpu;

	struct fpu *next_fpu = &next->fpu;

	int cpu = smp_processor_id();



	WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ENTRY) &&
@@ -620,7 +619,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p) 
	this_cpu_write(current_task, next_p);

	this_cpu_write(cpu_current_top_of_stack, task_top_of_stack(next_p));



	switch_fpu_finish(next_fpu);

	switch_fpu_finish();



	/* Reload sp0. */

	update_task_stack(next_p);