Commit 94a8d87c authored by Luca Coelho's avatar Luca Coelho
Browse files

iwlwifi: mvm: pre-initialize alive_data in wait_alive() 



The function we pass to the wait alive notification procedure may may
not even get called if the timeout occurs before the function is
called.  To prevent accessing unitialized data in alive_data, pre-set
it to zero in the declaration.  Found by static analyzers.

Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent e78da25e

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static int iwl_mvm_load_ucode_wait_alive(struct iwl_mvm *mvm, 
					 enum iwl_ucode_type ucode_type)

{

	struct iwl_notification_wait alive_wait;

	struct iwl_mvm_alive_data alive_data;

	struct iwl_mvm_alive_data alive_data = {};

	const struct fw_img *fw;

	int ret;

	enum iwl_ucode_type old_type = mvm->fwrt.cur_fw_img;