Commit 94a7b669 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Bartosz Golaszewski
Browse files

gpio: xgene: simplify probe, return devm_gpiochip_add_data() directly 



The handling of the return value from devm_gpiochip_add_data() is a bit
redundant. It prints messages on error and success cases.
While the success message may be useful, it is more in the area of log
spam, and these can be printed with other forms of kernel logging.

This change does a direct return with devm_gpiochip_add_data() in the probe
function.

The platform_set_drvdata() is needed, as this driver uses the stored
private date in the PM suspend/resume routines.

Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 91d594b2

drivers/gpio/gpio-xgene.c

+1 −10
Original line number Diff line number Diff line
@@ -159,7 +159,6 @@ static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume); 
static int xgene_gpio_probe(struct platform_device *pdev)

{

	struct xgene_gpio *gpio;

	int err = 0;



	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);

	if (!gpio)
@@ -183,15 +182,7 @@ static int xgene_gpio_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, gpio);



	err = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);

	if (err) {

		dev_err(&pdev->dev,

			"failed to register gpiochip.\n");

		return err;

	}



	dev_info(&pdev->dev, "X-Gene GPIO driver registered.\n");

	return 0;

	return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);

}



static const struct of_device_id xgene_gpio_of_match[] = {