Commit 93bea2fa authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_proto: use cros_ec_map_error() 



Use cros_ec_map_error() in cros_ec_get_host_event_wake_mask().

The behavior of cros_ec_get_host_event_wake_mask() slightly changed.  It
is acceptable because the caller only needs it returns negative integers
for indicating errors.  Especially, the EC_RES_INVALID_COMMAND still
maps to -EOPNOTSUPP.

Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220609084957.3684698-7-tzungbi@kernel.org
parent 8e399161

drivers/platform/chrome/cros_ec_proto.c

+4 −5
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static int cros_ec_get_host_event_wake_mask(struct cros_ec_device *ec_dev, 
					    uint32_t *mask)

{

	struct ec_response_host_event_mask *r;

	int ret;

	int ret, mapped;



	msg->command = EC_CMD_HOST_EVENT_GET_WAKE_MASK;

	msg->version = 0;
@@ -256,10 +256,9 @@ static int cros_ec_get_host_event_wake_mask(struct cros_ec_device *ec_dev, 


	ret = send_command(ec_dev, msg);

	if (ret >= 0) {

		if (msg->result == EC_RES_INVALID_COMMAND)

			return -EOPNOTSUPP;

		if (msg->result != EC_RES_SUCCESS)

			return -EPROTO;

		mapped = cros_ec_map_error(msg->result);

		if (mapped)

			return mapped;

	}

	if (ret > 0) {

		r = (struct ec_response_host_event_mask *)msg->data;