Commit 938e30c9 authored by Luciano Coelho's avatar Luciano Coelho Committed by John W. Linville
Browse files

wl1271: fix sparse warnings about undeclared functions 



The following sparse warnings were fixed:

drivers/net/wireless/wl12xx/wl1271_spi.c:199:6: warning: symbol 'wl1271_spi_read_busy' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:84:5: warning: symbol 'wl1271_cmd_cal_channel_tune' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:107:5: warning: symbol 'wl1271_cmd_cal_update_ref_point' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:132:5: warning: symbol 'wl1271_cmd_cal_p2g' was not declared. Should it be static?
drivers/net/wireless/wl12xx/wl1271_cmd.c:153:5: warning: symbol 'wl1271_cmd_cal' was not declared. Should it be static?

Reported-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarLuciano Coelho <luciano.coelho@nokia.com>
Reviewed-by: default avatarJuuso Oikarinen <juuso.oikarinen@nokia.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 7a38079e

drivers/net/wireless/wl12xx/wl1271_cmd.c

+4 −4
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len) 
	return ret;

}



int wl1271_cmd_cal_channel_tune(struct wl1271 *wl)

static int wl1271_cmd_cal_channel_tune(struct wl1271 *wl)

{

	struct wl1271_cmd_cal_channel_tune *cmd;

	int ret = 0;
@@ -104,7 +104,7 @@ int wl1271_cmd_cal_channel_tune(struct wl1271 *wl) 
	return ret;

}



int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl)

static int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl)

{

	struct wl1271_cmd_cal_update_ref_point *cmd;

	int ret = 0;
@@ -129,7 +129,7 @@ int wl1271_cmd_cal_update_ref_point(struct wl1271 *wl) 
	return ret;

}



int wl1271_cmd_cal_p2g(struct wl1271 *wl)

static int wl1271_cmd_cal_p2g(struct wl1271 *wl)

{

	struct wl1271_cmd_cal_p2g *cmd;

	int ret = 0;
@@ -150,7 +150,7 @@ int wl1271_cmd_cal_p2g(struct wl1271 *wl) 
	return ret;

}



int wl1271_cmd_cal(struct wl1271 *wl)

static int wl1271_cmd_cal(struct wl1271 *wl)

{

	/*

	 * FIXME: we must make sure that we're not sleeping when calibration

drivers/net/wireless/wl12xx/wl1271_spi.c

+4 −1
Original line number Diff line number Diff line
@@ -196,7 +196,9 @@ int wl1271_set_partition(struct wl1271 *wl, 


#define WL1271_BUSY_WORD_TIMEOUT 1000



void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len)

/* FIXME: Check busy words, removed due to SPI bug */

#if 0

static void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len)

{

	struct spi_transfer t[1];

	struct spi_message m;
@@ -256,6 +258,7 @@ void wl1271_spi_read_busy(struct wl1271 *wl, void *buf, size_t len) 
	memset(buf, 0, len);

	wl1271_error("SPI read busy-word timeout!\n");

}

#endif



void wl1271_spi_raw_read(struct wl1271 *wl, int addr, void *buf,

			 size_t len, bool fixed)