Commit 934616e8 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: light: rpr0521: Balance runtime pm + use pm_runtime_resume_and_get() 



Calls to pm_runtime_put_noidle in probe() error path and remove() are
not match to any get() calls.

The runtime pm core protects against negative reference counts, so this
doesn't have any visible impact beyond confusing the reader.

Whilst here use pm_runtime_resume_and_get() to replace boilerplate.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com>
Reviewed-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20210509113354.660190-11-jic23@kernel.org
parent 264da512

drivers/iio/light/rpr0521.c

+1 −6
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ static int rpr0521_set_power_state(struct rpr0521_data *data, bool on, 
	 * both stay enabled until _suspend().

	 */

	if (on) {

		ret = pm_runtime_get_sync(&data->client->dev);

		ret = pm_runtime_resume_and_get(&data->client->dev);

	} else {

		pm_runtime_mark_last_busy(&data->client->dev);

		ret = pm_runtime_put_autosuspend(&data->client->dev);
@@ -369,9 +369,6 @@ static int rpr0521_set_power_state(struct rpr0521_data *data, bool on, 
		dev_err(&data->client->dev,

			"Failed: rpr0521_set_power_state for %d, ret %d\n",

			on, ret);

		if (on)

			pm_runtime_put_noidle(&data->client->dev);



		return ret;

	}
@@ -1038,7 +1035,6 @@ static int rpr0521_probe(struct i2c_client *client, 
err_pm_disable:

	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);

	pm_runtime_put_noidle(&client->dev);

err_poweroff:

	rpr0521_poweroff(data);
@@ -1053,7 +1049,6 @@ static int rpr0521_remove(struct i2c_client *client) 


	pm_runtime_disable(&client->dev);

	pm_runtime_set_suspended(&client->dev);

	pm_runtime_put_noidle(&client->dev);



	rpr0521_poweroff(iio_priv(indio_dev));