Commit 92a5e882 authored by Lee Jones's avatar Lee Jones Committed by Jens Axboe
Browse files

ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description 



Fixes the following W=1 kernel build warning(s):

 drivers/ata/pata_optidma.c:298: warning: expecting prototype for optidma_make_bits(). Prototype was for optidma_make_bits43() instead
 drivers/ata/pata_optidma.c:319: warning: Function parameter or member 'r_failed' not described in 'optidma_set_mode'
 drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev' not described in 'optiplus_with_udma'

Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent efd2cbe8

drivers/ata/pata_optidma.c

+3 −2
Original line number Diff line number Diff line
@@ -287,7 +287,7 @@ static void optiplus_set_dma_mode(struct ata_port *ap, struct ata_device *adev) 
}



/**

 *	optidma_make_bits	-	PCI setup helper

 *	optidma_make_bits43	-	PCI setup helper

 *	@adev: ATA device

 *

 *	Turn the ATA device setup into PCI configuration bits
@@ -309,6 +309,7 @@ static u8 optidma_make_bits43(struct ata_device *adev) 
/**

 *	optidma_set_mode	-	mode setup

 *	@link: link to set up

 *	@r_failed: out parameter for failed device

 *

 *	Use the standard setup to tune the chipset and then finalise the

 *	configuration by writing the nibble of extra bits of data into
@@ -354,7 +355,7 @@ static struct ata_port_operations optiplus_port_ops = { 


/**

 *	optiplus_with_udma	-	Look for UDMA capable setup

 *	@pdev; ATA controller

 *	@pdev: ATA controller

 */



static int optiplus_with_udma(struct pci_dev *pdev)