Commit 91ceae37 authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

NET: pc300, move to staging as it is broken 

It was marked as BROKEN back in 2008. It is because the tty handling
in the driver is really broken.

There was some activity in January 2012 to fix the driver, but the
patch was commented to be bogus:
  https://lkml.org/lkml/2012/1/29/160
and we have not heard back from the author since then:
  https://lkml.org/lkml/2012/3/28/412



So since nobody stepped in and rewrote the driver, it is time to move
it out of line now. And drop it some time later if nobody comes up
with patches to fix the driver in staging.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andrea Shepard <andrea@persephoneslair.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b330f606

drivers/net/wan/Kconfig

+0 −31
Original line number Diff line number Diff line
@@ -203,37 +203,6 @@ config WANXL_BUILD_FIRMWARE 


	  You should never need this option, say N.



config PC300

	tristate "Cyclades-PC300 support (RS-232/V.35, X.21, T1/E1 boards)"

	depends on HDLC && PCI && BROKEN

	---help---

	  This driver is broken because of struct tty_driver change.



	  Driver for the Cyclades-PC300 synchronous communication boards.



	  These boards provide synchronous serial interfaces to your

	  Linux box (interfaces currently available are RS-232/V.35, X.21 and

	  T1/E1). If you wish to support Multilink PPP, please select the

	  option later and read the file README.mlppp provided by PC300

	  package.



	  To compile this as a module, choose M here: the module

	  will be called pc300.



	  If unsure, say N.



config PC300_MLPPP

	bool "Cyclades-PC300 MLPPP support"

	depends on PC300 && PPP_MULTILINK && PPP_SYNC_TTY && HDLC_PPP

	help

	  Multilink PPP over the PC300 synchronous communication boards.



comment "Cyclades-PC300 MLPPP support is disabled."

	depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)



comment "Refer to the file README.mlppp, provided by PC300 package."

	depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)



config PC300TOO

	tristate "Cyclades PC300 RSV/X21 alternative support"

	depends on HDLC && PCI

drivers/net/wan/Makefile

+0 −5
Original line number Diff line number Diff line
@@ -17,10 +17,6 @@ obj-$(CONFIG_HDLC_FR) += hdlc_fr.o 
obj-$(CONFIG_HDLC_PPP)		+= hdlc_ppp.o

obj-$(CONFIG_HDLC_X25)		+= hdlc_x25.o



pc300-y				:= pc300_drv.o

pc300-$(CONFIG_PC300_MLPPP)	+= pc300_tty.o

pc300-objs			:= $(pc300-y)



obj-$(CONFIG_HOSTESS_SV11)	+= z85230.o	hostess_sv11.o

obj-$(CONFIG_SEALEVEL_4021)	+= z85230.o	sealevel.o

obj-$(CONFIG_COSA)		+= cosa.o
@@ -35,7 +31,6 @@ obj-$(CONFIG_SDLA) += sdla.o 
obj-$(CONFIG_CYCLADES_SYNC)	+= cycx_drv.o cyclomx.o

obj-$(CONFIG_LAPBETHER)		+= lapbether.o

obj-$(CONFIG_SBNI)		+= sbni.o

obj-$(CONFIG_PC300)		+= pc300.o

obj-$(CONFIG_N2)		+= n2.o

obj-$(CONFIG_C101)		+= c101.o

obj-$(CONFIG_WANXL)		+= wanxl.o

drivers/staging/Kconfig

+2 −0
Original line number Diff line number Diff line
@@ -120,6 +120,8 @@ source "drivers/staging/nvec/Kconfig" 


source "drivers/staging/media/Kconfig"



source "drivers/staging/net/Kconfig"



source "drivers/staging/omapdrm/Kconfig"



source "drivers/staging/android/Kconfig"

drivers/staging/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 
obj-$(CONFIG_STAGING)		+= staging.o



obj-y				+= media/

obj-y				+= net/

obj-$(CONFIG_ET131X)		+= et131x/

obj-$(CONFIG_SLICOSS)		+= slicoss/

obj-$(CONFIG_USBIP_CORE)	+= usbip/

drivers/staging/net/Kconfig

0 → 100644
+38 −0
Original line number Diff line number Diff line 
if NETDEVICES



if WAN



config PC300

	tristate "Cyclades-PC300 support (RS-232/V.35, X.21, T1/E1 boards)"

	depends on HDLC && PCI && BROKEN

	---help---

	  This driver is broken because of struct tty_driver change.



	  Driver for the Cyclades-PC300 synchronous communication boards.



	  These boards provide synchronous serial interfaces to your

	  Linux box (interfaces currently available are RS-232/V.35, X.21 and

	  T1/E1). If you wish to support Multilink PPP, please select the

	  option later and read the file README.mlppp provided by PC300

	  package.



	  To compile this as a module, choose M here: the module

	  will be called pc300.



	  If unsure, say N.



config PC300_MLPPP

	bool "Cyclades-PC300 MLPPP support"

	depends on PC300 && PPP_MULTILINK && PPP_SYNC_TTY && HDLC_PPP

	help

	  Multilink PPP over the PC300 synchronous communication boards.



comment "Cyclades-PC300 MLPPP support is disabled."

	depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)



comment "Refer to the file README.mlppp, provided by PC300 package."

	depends on HDLC && PC300 && (PPP=n || !PPP_MULTILINK || PPP_SYNC_TTY=n || !HDLC_PPP)



endif # WAN



endif # NETDEVICES