Commit 91ca9c3a authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luca Coelho
Browse files

iwlwifi: don't dump_stack() when we get an unexpected interrupt 



It is yet unclear if the WARNING really points to a real problem,
but for sure the stack dump doesn't help fixing it.
Just use a regular error print instead.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220205112029.a79e733a12f7.I8189344294222be0589fa43cc70fdf38e3057045@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 63b62a2d

drivers/net/wireless/intel/iwlwifi/pcie/rx.c

+6 −3
Original line number Diff line number Diff line
@@ -1627,10 +1627,13 @@ irqreturn_t iwl_pcie_irq_rx_msix_handler(int irq, void *dev_id) 
	if (WARN_ON(entry->entry >= trans->num_rx_queues))

		return IRQ_NONE;



	if (WARN_ONCE(!rxq,

		      "[%d] Got MSI-X interrupt before we have Rx queues",

		      entry->entry))

	if (!rxq) {

		if (net_ratelimit())

			IWL_ERR(trans,

				"[%d] Got MSI-X interrupt before we have Rx queues\n",

				entry->entry);

		return IRQ_NONE;

	}



	lock_map_acquire(&trans->sync_cmd_lockdep_map);

	IWL_DEBUG_ISR(trans, "[%d] Got interrupt\n", entry->entry);