Commit 9100c359 authored by Melissa Wen's avatar Melissa Wen Committed by Alex Deucher
Browse files

drm/amd/display: dc_link: code clean up on enable_link_dp function 



Coding style clean up on enable_link_dp function as suggested by
checkpatch.pl:

CHECK: Lines should not end with a '('
WARNING: line over 80 characters
WARNING: suspect code indent for conditional statements (8, 24)
CHECK: braces {} should be used on all arms of this statement
ERROR: else should follow close brace '}'
CHECK: Comparison to NULL could be written
       "link->preferred_training_settings.fec_enable"

Signed-off-by: default avatarMelissa Wen <melissa.srw@gmail.com>
Reviewed-by: default avatarRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e599f01f

drivers/gpu/drm/amd/display/dc/core/dc_link.c

+14 −15
Original line number Diff line number Diff line
@@ -1498,8 +1498,7 @@ static void enable_stream_features(struct pipe_ctx *pipe_ctx) 
	}

}



static enum dc_status enable_link_dp(

		struct dc_state *state,

static enum dc_status enable_link_dp(struct dc_state *state,

				     struct pipe_ctx *pipe_ctx)

{

	struct dc_stream_state *stream = pipe_ctx->stream;
@@ -1532,7 +1531,8 @@ static enum dc_status enable_link_dp( 
	pipe_ctx->stream_res.pix_clk_params.requested_sym_clk =

			link_settings.link_rate * LINK_RATE_REF_FREQ_IN_KHZ;

	if (state->clk_mgr && !apply_seamless_boot_optimization)

		state->clk_mgr->funcs->update_clocks(state->clk_mgr, state, false);

		state->clk_mgr->funcs->update_clocks(state->clk_mgr,

						     state, false);



	// during mode switch we do DP_SET_POWER off then on, and OUI is lost

	dpcd_set_source_specific_data(link);
@@ -1542,19 +1542,18 @@ static enum dc_status enable_link_dp( 
	if (link_settings.link_rate == LINK_RATE_LOW)

		skip_video_pattern = false;



	if (perform_link_training_with_retries(

			&link_settings,

	if (perform_link_training_with_retries(&link_settings,

					       skip_video_pattern,

					       LINK_TRAINING_ATTEMPTS,

					       pipe_ctx,

					       pipe_ctx->stream->signal)) {

		link->cur_link_settings = link_settings;

		status = DC_OK;

	}

	else

	} else {

		status = DC_FAIL_DP_LINK_TRAINING;

	}



	if (link->preferred_training_settings.fec_enable != NULL)

	if (link->preferred_training_settings.fec_enable)

		fec_enable = *link->preferred_training_settings.fec_enable;

	else

		fec_enable = true;