Commit 90f3de61 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Oded Gabbay
Browse files

accel/habanalabs/gaudi2: Fix incorrect string length computation in gaudi2_psoc_razwi_get_engines() 



snprintf() returns the "number of characters which *would* be generated for
the given input", not the size *really* generated.

In order to avoid too large values for 'str_size' (and potential negative
values for "PSOC_RAZWI_ENG_STR_SIZE - str_size") use scnprintf()
instead of snprintf().

Fixes: c0e6df91 ("accel/habanalabs: fix address decode RAZWI handling")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent a45d5cf0

drivers/accel/habanalabs/gaudi2/gaudi2.c

+2 −2
Original line number Diff line number Diff line
@@ -8278,11 +8278,11 @@ static int gaudi2_psoc_razwi_get_engines(struct gaudi2_razwi_info *razwi_info, u 
		eng_id[num_of_eng] = razwi_info[i].eng_id;

		base[num_of_eng] = razwi_info[i].rtr_ctrl;

		if (!num_of_eng)

			str_size += snprintf(eng_name + str_size,

			str_size += scnprintf(eng_name + str_size,

						PSOC_RAZWI_ENG_STR_SIZE - str_size, "%s",

						razwi_info[i].eng_name);

		else

			str_size += snprintf(eng_name + str_size,

			str_size += scnprintf(eng_name + str_size,

						PSOC_RAZWI_ENG_STR_SIZE - str_size, " or %s",

						razwi_info[i].eng_name);

		num_of_eng++;