Commit 9082282f authored by Leo Yan's avatar Leo Yan Committed by Arnaldo Carvalho de Melo
Browse files

perf c2c: Add dimensions of peer metrics for cache line view 



This patch adds dimensions of peer ops, which will be used for Shared
cache line distribution pareto.

It adds the percentage dimensions for local and remote peer operations,
and the dimensions for accounting operation numbers which is used for
stdio mode.

Reviewed-by: default avatarAli Saidi <alisaidi@amazon.com>
Signed-off-by: default avatarLeo Yan <leo.yan@linaro.org>
Tested-by: default avatarAli Saidi <alisaidi@amazon.com>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.garry@huawei.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Like Xu <likexu@tencent.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Timothy Hayes <timothy.hayes@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20220811062451.435810-8-leo.yan@linaro.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 63e74ab5

tools/perf/builtin-c2c.c

+102 −0
Original line number Diff line number Diff line
@@ -902,6 +902,8 @@ static double percent_ ## __f(struct c2c_hist_entry *c2c_he) \ 


PERCENT_FN(rmt_hitm)

PERCENT_FN(lcl_hitm)

PERCENT_FN(rmt_peer)

PERCENT_FN(lcl_peer)

PERCENT_FN(st_l1hit)

PERCENT_FN(st_l1miss)

PERCENT_FN(st_na)
@@ -968,6 +970,68 @@ percent_lcl_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused, 
	return per_left - per_right;

}



static int

percent_lcl_peer_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,

		       struct hist_entry *he)

{

	int width = c2c_width(fmt, hpp, he->hists);

	double per = PERCENT(he, lcl_peer);

	char buf[10];



	return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per));

}



static int

percent_lcl_peer_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,

		       struct hist_entry *he)

{

	return percent_color(fmt, hpp, he, percent_lcl_peer);

}



static int64_t

percent_lcl_peer_cmp(struct perf_hpp_fmt *fmt __maybe_unused,

		     struct hist_entry *left, struct hist_entry *right)

{

	double per_left;

	double per_right;



	per_left  = PERCENT(left, lcl_peer);

	per_right = PERCENT(right, lcl_peer);



	return per_left - per_right;

}



static int

percent_rmt_peer_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,

		       struct hist_entry *he)

{

	int width = c2c_width(fmt, hpp, he->hists);

	double per = PERCENT(he, rmt_peer);

	char buf[10];



	return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per));

}



static int

percent_rmt_peer_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,

		       struct hist_entry *he)

{

	return percent_color(fmt, hpp, he, percent_rmt_peer);

}



static int64_t

percent_rmt_peer_cmp(struct perf_hpp_fmt *fmt __maybe_unused,

		     struct hist_entry *left, struct hist_entry *right)

{

	double per_left;

	double per_right;



	per_left  = PERCENT(left, rmt_peer);

	per_right = PERCENT(right, rmt_peer);



	return per_left - per_right;

}



static int

percent_stores_l1hit_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,

			   struct hist_entry *he)
@@ -1403,6 +1467,22 @@ static struct c2c_dimension dim_cl_lcl_hitm = { 
	.width		= 7,

};



static struct c2c_dimension dim_cl_rmt_peer = {

	.header		= HEADER_SPAN("----- Peer -----", "Rmt", 1),

	.name		= "cl_rmt_peer",

	.cmp		= rmt_peer_cmp,

	.entry		= rmt_peer_entry,

	.width		= 7,

};



static struct c2c_dimension dim_cl_lcl_peer = {

	.header		= HEADER_SPAN_LOW("Lcl"),

	.name		= "cl_lcl_peer",

	.cmp		= lcl_peer_cmp,

	.entry		= lcl_peer_entry,

	.width		= 7,

};



static struct c2c_dimension dim_tot_stores = {

	.header		= HEADER_BOTH("Total", "Stores"),

	.name		= "tot_stores",
@@ -1547,6 +1627,24 @@ static struct c2c_dimension dim_percent_lcl_hitm = { 
	.width		= 7,

};



static struct c2c_dimension dim_percent_rmt_peer = {

	.header		= HEADER_SPAN("-- Peer Snoop --", "Rmt", 1),

	.name		= "percent_rmt_peer",

	.cmp		= percent_rmt_peer_cmp,

	.entry		= percent_rmt_peer_entry,

	.color		= percent_rmt_peer_color,

	.width		= 7,

};



static struct c2c_dimension dim_percent_lcl_peer = {

	.header		= HEADER_SPAN_LOW("Lcl"),

	.name		= "percent_lcl_peer",

	.cmp		= percent_lcl_peer_cmp,

	.entry		= percent_lcl_peer_entry,

	.color		= percent_lcl_peer_color,

	.width		= 7,

};



static struct c2c_dimension dim_percent_stores_l1hit = {

	.header		= HEADER_SPAN("------- Store Refs ------", "L1 Hit", 2),

	.name		= "percent_stores_l1hit",
@@ -1704,6 +1802,8 @@ static struct c2c_dimension *dimensions[] = { 
	&dim_rmt_peer,

	&dim_cl_lcl_hitm,

	&dim_cl_rmt_hitm,

	&dim_cl_lcl_peer,

	&dim_cl_rmt_peer,

	&dim_tot_stores,

	&dim_stores_l1hit,

	&dim_stores_l1miss,
@@ -1721,6 +1821,8 @@ static struct c2c_dimension *dimensions[] = { 
	&dim_percent_hitm,

	&dim_percent_rmt_hitm,

	&dim_percent_lcl_hitm,

	&dim_percent_rmt_peer,

	&dim_percent_lcl_peer,

	&dim_percent_stores_l1hit,

	&dim_percent_stores_l1miss,

	&dim_percent_stores_na,