Commit 8f9a791a authored by Ilan Peer's avatar Ilan Peer Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: Fix key flags for IGTK on AP interface 



When an IGTK is installed for an AP interface, there is no station
associated with it. However, the MFP flag must be set for the installed
key as otherwise the FW wouldn't use it.

Fix the security key flag to set the MFP flag also when the AP is
an AP interface and the key index matches that of an IGTK.

Fixes: 5c75a208 ("wifi: iwlwifi: mvm: support new key API")
Signed-off-by: default avatarIlan Peer <ilan.peer@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20231011130030.f67005e2d4d2.I6832c6e87f3c79fff00689eb10a3a30810e1ee83@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 8bbe27db

drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c

+6 −1
Original line number Diff line number Diff line
@@ -96,7 +96,12 @@ u32 iwl_mvm_get_sec_flags(struct iwl_mvm *mvm, 
	if (!sta && vif->type == NL80211_IFTYPE_STATION)

		sta = mvmvif->ap_sta;



	if (!IS_ERR_OR_NULL(sta) && sta->mfp)

	/* Set the MFP flag also for an AP interface where the key is an IGTK

	 * key as in such a case the station would always be NULL

	 */

	if ((!IS_ERR_OR_NULL(sta) && sta->mfp) ||

	    (vif->type == NL80211_IFTYPE_AP &&

	     (keyconf->keyidx == 4 || keyconf->keyidx == 5)))

		flags |= IWL_SEC_KEY_FLAG_MFP;



	return flags;