Commit 8f3c307b authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Nishanth Menon
Browse files

soc: ti: pm33xx: Fix refcount leak in am33xx_pm_probe 



wkup_m3_ipc_get() takes refcount, which should be freed by
wkup_m3_ipc_put(). Add missing refcount release in the error paths.

Fixes: 5a99ae00 ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20230106054022.947529-1-linmq006@gmail.com


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
parent 5f1732a8

drivers/soc/ti/pm33xx.c

+3 −2
Original line number Diff line number Diff line
@@ -527,7 +527,7 @@ static int am33xx_pm_probe(struct platform_device *pdev) 


	ret = am33xx_pm_alloc_sram();

	if (ret)

		return ret;

		goto err_wkup_m3_ipc_put;



	ret = am33xx_pm_rtc_setup();

	if (ret)
@@ -572,13 +572,14 @@ static int am33xx_pm_probe(struct platform_device *pdev) 
	pm_runtime_put_sync(dev);

err_pm_runtime_disable:

	pm_runtime_disable(dev);

	wkup_m3_ipc_put(m3_ipc);

err_unsetup_rtc:

	iounmap(rtc_base_virt);

	clk_put(rtc_fck);

err_free_sram:

	am33xx_pm_free_sram();

	pm33xx_dev = NULL;

err_wkup_m3_ipc_put:

	wkup_m3_ipc_put(m3_ipc);

	return ret;

}