Commit 8e6e49cc authored by Dan Carpenter's avatar Dan Carpenter Committed by Leon Romanovsky
Browse files

RDMA/mlx5: Check reg_create() create for errors 



The reg_create() can fail.  Check for errors before dereferencing it.

Fixes: dd1b913f ("RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y+ERYy4wN0LsKsm+@kili


Reviewed-by: default avatarDevesh Sharma <devesh.s.sharma@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 68e41625

drivers/infiniband/hw/mlx5/mr.c

+2 −0
Original line number Diff line number Diff line
@@ -1166,6 +1166,8 @@ static struct mlx5_ib_mr *alloc_cacheable_mr(struct ib_pd *pd, 
		mutex_lock(&dev->slow_path_mutex);

		mr = reg_create(pd, umem, iova, access_flags, page_size, false);

		mutex_unlock(&dev->slow_path_mutex);

		if (IS_ERR(mr))

			return mr;

		mr->mmkey.rb_key = rb_key;

		return mr;

	}