Commit 8defea0e authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove test in usbctrl_vendorreq() 



Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). This test
is not necessary because io_buf has been assigned with the address of
a region of dynamically allocated memory (dvobj->usb_alloc_vendor_req_buf)
by rtw_init_intf_priv() in os_dep/usb_intf.c.

Co-developed-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20210924122705.3781-4-fmdefrancesco@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4b19eeff

drivers/staging/r8188eu/hal/usb_ops_linux.c

+1 −7
Original line number Diff line number Diff line
@@ -34,12 +34,6 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l 
	/*  Acquire IO memory for vendorreq */

	io_buf = dvobjpriv->usb_vendor_req_buf;



	if (!io_buf) {

		DBG_88E("[%s] io_buf == NULL\n", __func__);

		status = -ENOMEM;

		goto release_mutex;

	}



	if (requesttype == REALTEK_USB_VENQT_READ)

		pipe = usb_rcvctrlpipe(udev, 0);/* read_in */

	else
@@ -91,7 +85,7 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l 
		if ((value >= FW_8188E_START_ADDRESS && value <= FW_8188E_END_ADDRESS) || status == len)

			break;

	}

release_mutex:



	mutex_unlock(&dvobjpriv->usb_vendor_req_mutex);

exit:

	return status;