Commit 8c5f41ac authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

usb: ohci-pxa27x: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart from
emitting a warning) and this typically results in resource leaks. To improve
here there is a quest to make the remove callback return void. In the first
step of this quest all drivers are converted to .remove_new() which already
returns void. Eventually after all drivers are converted, .remove_new() is
renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230517230239.187727-72-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7b0b8100

drivers/usb/host/ohci-pxa27x.c

+2 −3
Original line number Diff line number Diff line
@@ -506,7 +506,7 @@ static int ohci_hcd_pxa27x_probe(struct platform_device *pdev) 
 * the HCD's stop() method.  It is always called from a thread

 * context, normally "rmmod", "apmd", or something similar.

 */

static int ohci_hcd_pxa27x_remove(struct platform_device *pdev)

static void ohci_hcd_pxa27x_remove(struct platform_device *pdev)

{

	struct usb_hcd *hcd = platform_get_drvdata(pdev);

	struct pxa27x_ohci *pxa_ohci = to_pxa27x_ohci(hcd);
@@ -519,7 +519,6 @@ static int ohci_hcd_pxa27x_remove(struct platform_device *pdev) 
		pxa27x_ohci_set_vbus_power(pxa_ohci, i, false);



	usb_put_hcd(hcd);

	return 0;

}



/*-------------------------------------------------------------------------*/
@@ -577,7 +576,7 @@ static const struct dev_pm_ops ohci_hcd_pxa27x_pm_ops = { 


static struct platform_driver ohci_hcd_pxa27x_driver = {

	.probe		= ohci_hcd_pxa27x_probe,

	.remove		= ohci_hcd_pxa27x_remove,

	.remove_new	= ohci_hcd_pxa27x_remove,

	.shutdown	= usb_hcd_platform_shutdown,

	.driver		= {

		.name	= "pxa27x-ohci",