Commit 8b018718 authored by Ivan Safonov's avatar Ivan Safonov Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: add release_firmware() between request_firmware and function error exit 



Small memory leak fixed.

Signed-off-by: default avatarIvan Safonov <insafonov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 29e20dd4

drivers/staging/rtl8188eu/hal/fw.c

+4 −1
Original line number Diff line number Diff line
@@ -175,14 +175,17 @@ int rtl88eu_download_fw(struct adapter *adapt) 
	if (fw->size > FW_8188E_SIZE) {

		dev_err(device, "Firmware size exceed 0x%X. Check it.\n",

			FW_8188E_SIZE);

		release_firmware(fw);

		return -1;

	}



	trailing_zeros_length = (4 - fw->size % 4) % 4;



	fw_data = kmalloc(fw->size + trailing_zeros_length, GFP_KERNEL);

	if (!fw_data)

	if (!fw_data) {

		release_firmware(fw);

		return -ENOMEM;

	}



	memcpy(fw_data, fw->data, fw->size);

	memset(fw_data + fw->size, 0, trailing_zeros_length);