Commit 8a7e2d2e authored by Anders Roxell's avatar Anders Roxell Committed by Shuah Khan (Samsung OSG)
Browse files

cpupower: remove stringop-truncation waring 



The strncpy doesn't null terminate the string because the size is too
short by one byte.

parse.c: In function ‘prepare_default_config’:
parse.c:148:2: warning: ‘strncpy’ output truncated before terminating
    nul copying 8 bytes from a string of the same length
    [-Wstringop-truncation]
  strncpy(config->governor, "ondemand", 8);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The normal method of passing the length of the destination buffer works
correctly here.

Fixes: 7fe2f639 ("cpupowerutils - cpufrequtils extended with quite some features")
Signed-off-by: default avatarAnders Roxell <anders.roxell@linaro.org>
Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent 5b394b2d

tools/power/cpupower/bench/parse.c

+1 −1
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ struct config *prepare_default_config() 
	config->cpu = 0;

	config->prio = SCHED_HIGH;

	config->verbose = 0;

	strncpy(config->governor, "ondemand", 8);

	strncpy(config->governor, "ondemand", sizeof(config->governor));



	config->output = stdout;