Commit 8749c278 authored by Yang Yingliang's avatar Yang Yingliang Committed by Oded Gabbay
Browse files

habanalabs: fix return value check in hl_fw_get_sec_attest_data() 



If hl_cpu_accessible_dma_pool_alloc() fails, we should check
'req_cpu_addr', fix it.

Fixes: 0c88760f ("habanalabs/gaudi2: add secured attestation info uapi")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 210a671c

drivers/misc/habanalabs/common/firmware_if.c

+1 −1
Original line number Diff line number Diff line
@@ -2983,7 +2983,7 @@ static int hl_fw_get_sec_attest_data(struct hl_device *hdev, u32 packet_id, void 
	int rc;



	req_cpu_addr = hl_cpu_accessible_dma_pool_alloc(hdev, size, &req_dma_addr);

	if (!data) {

	if (!req_cpu_addr) {

		dev_err(hdev->dev,

			"Failed to allocate DMA memory for CPU-CP packet %u\n", packet_id);

		return -ENOMEM;