Commit 85c5cbeb authored by Wang Hai's avatar Wang Hai Committed by Greg Kroah-Hartman
Browse files

cxl: Fix kobject memleak 



Currently the error return path from kobject_init_and_add() is not
followed by a call to kobject_put() - which means we are leaking
the kobject.

Fix it by adding a call to kobject_put() in the error path of
kobject_init_and_add().

Fixes: b087e619 ("cxl: Export optional AFU configuration record in sysfs")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
Acked-by: default avatarAndrew Donnellan <ajd@linux.ibm.com>
Acked-by: default avatarFrederic Barrat <fbarrat@linux.ibm.com>
Link: https://lore.kernel.org/r/20200602120733.5943-1-wanghai38@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9ebcfadb

drivers/misc/cxl/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -624,7 +624,7 @@ static struct afu_config_record *cxl_sysfs_afu_new_cr(struct cxl_afu *afu, int c 
	rc = kobject_init_and_add(&cr->kobj, &afu_config_record_type,

				  &afu->dev.kobj, "cr%i", cr->cr);

	if (rc)

		goto err;

		goto err1;



	rc = sysfs_create_bin_file(&cr->kobj, &cr->config_attr);

	if (rc)