Commit 853450a6 authored by Miri Korenblit's avatar Miri Korenblit Committed by Luca Coelho
Browse files

iwlwifi: mvm: use debug print instead of WARN_ON() 



In MCC_UPDATE_CMD we get from the FW the number of entries in the
channel info array. We used to WARN_ON if this parameter is greater
than we expected. Since this is not really a driver bug, and since it
might happen in some valid cases too, we shouldn't use a warning here.

Fix this by replacing the WARN_ON with a debug print.

Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220130115024.3cb9828df280.I14abe7c71b45bbae3d3cd503e6e13fa2cd372ed4@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 3ea839c1

drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c

+5 −1
Original line number Diff line number Diff line
@@ -1387,8 +1387,12 @@ iwl_parse_nvm_mcc_info(struct device *dev, const struct iwl_cfg *cfg, 
		nvm_chan = iwl_nvm_channels;

	}



	if (WARN_ON(num_of_ch > max_num_ch))

	if (num_of_ch > max_num_ch) {

		IWL_DEBUG_DEV(dev, IWL_DL_LAR,

			      "Num of channels (%d) is greater than expected. Truncating to %d\n",

			      num_of_ch, max_num_ch);

		num_of_ch = max_num_ch;

	}



	if (WARN_ON_ONCE(num_of_ch > NL80211_MAX_SUPP_REG_RULES))

		return ERR_PTR(-EINVAL);