Commit 825f79ae authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: fw-core: destroy connections on error 



In one of the error cases we aren't destroying the connections created
earlier. Fix it.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 4aea5a15

drivers/staging/greybus/fw-core.c

+1 −2
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, 
			dev_err(&bundle->dev, "invalid protocol id (0x%02x)\n",

				protocol_id);

			ret = -EINVAL;

			goto err_free_fw_core;

			goto err_destroy_connections;

		}

	}
@@ -187,7 +187,6 @@ static int gb_fw_core_probe(struct gb_bundle *bundle, 
	gb_connection_destroy(fw_core->mgmt_connection);

	gb_connection_destroy(fw_core->spi_connection);

	gb_connection_destroy(fw_core->download_connection);

err_free_fw_core:

	kfree(fw_core);



	return ret;