Commit 7fd890b8 authored by Michael Tretter's avatar Michael Tretter Committed by Michal Simek
Browse files

soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver 



PM_INIT_FINALIZE tells the PMU FW that Linux is able to handle the power
management nodes that are provided by the PMU FW. Nodes that are not
requested are shut down after this call.

Calling PM_INIT_FINALIZE from the zynqmp_power driver is wrong. The PM
node request mechanism is implemented in the zynqmp_pm_domains driver,
which must also call PM_INIT_FINALIZE.

Due to the behavior of the PMU FW, all devices must be powered up before
PM_INIT_FINALIZE is called, because otherwise the devices might
misbehave. Calling PM_INIT_FINALIZE from the sync_state device callback
ensures that all users probed successfully before the PMU FW is allowed
to power off unused domains.

Signed-off-by: default avatarMichael Tretter <m.tretter@pengutronix.de>
Acked-by: default avatarMichal Simek <michal.simek@xilinx.com>
Acked-by: default avatarRajan Vaja <rajan.vaja@xilinx.com>
Link: https://lore.kernel.org/r/20210825150313.4033156-2-m.tretter@pengutronix.de


Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
parent fa55b7dc

drivers/soc/xilinx/zynqmp_pm_domains.c

+16 −0
Original line number Diff line number Diff line
@@ -152,11 +152,17 @@ static int zynqmp_gpd_power_off(struct generic_pm_domain *domain) 
static int zynqmp_gpd_attach_dev(struct generic_pm_domain *domain,

				 struct device *dev)

{

	struct device_link *link;

	int ret;

	struct zynqmp_pm_domain *pd;



	pd = container_of(domain, struct zynqmp_pm_domain, gpd);



	link = device_link_add(dev, &domain->dev, DL_FLAG_SYNC_STATE_ONLY);

	if (!link)

		dev_dbg(&domain->dev, "failed to create device link for %s\n",

			dev_name(dev));



	/* If this is not the first device to attach there is nothing to do */

	if (domain->device_count)

		return 0;
@@ -299,9 +305,19 @@ static int zynqmp_gpd_remove(struct platform_device *pdev) 
	return 0;

}



static void zynqmp_gpd_sync_state(struct device *dev)

{

	int ret;



	ret = zynqmp_pm_init_finalize();

	if (ret)

		dev_warn(dev, "failed to release power management to firmware\n");

}



static struct platform_driver zynqmp_power_domain_driver = {

	.driver	= {

		.name = "zynqmp_power_controller",

		.sync_state = zynqmp_gpd_sync_state,

	},

	.probe = zynqmp_gpd_probe,

	.remove = zynqmp_gpd_remove,

drivers/soc/xilinx/zynqmp_power.c

+0 −1
Original line number Diff line number Diff line
@@ -178,7 +178,6 @@ static int zynqmp_pm_probe(struct platform_device *pdev) 
	u32 pm_api_version;

	struct mbox_client *client;



	zynqmp_pm_init_finalize();

	zynqmp_pm_get_api_version(&pm_api_version);



	/* Check PM API version number */