Commit 7dcdbd95 authored by Al Viro's avatar Al Viro Committed by David S. Miller
Browse files

[SCTP]: Don't bother setting sin_port in ->from_sk(). 



... the only caller will overwrite immediately

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 516b20ee

net/sctp/ipv6.c

+1 −1
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ static void sctp_v6_from_skb(union sctp_addr *addr,struct sk_buff *skb, 
static void sctp_v6_from_sk(union sctp_addr *addr, struct sock *sk)

{

	addr->v6.sin6_family = AF_INET6;

	addr->v6.sin6_port = inet_sk(sk)->num;

	addr->v6.sin6_port = 0;

	addr->v6.sin6_addr = inet6_sk(sk)->rcv_saddr;

}

net/sctp/protocol.c

+1 −1
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ static void sctp_v4_from_skb(union sctp_addr *addr, struct sk_buff *skb, 
static void sctp_v4_from_sk(union sctp_addr *addr, struct sock *sk)

{

	addr->v4.sin_family = AF_INET;

	addr->v4.sin_port = inet_sk(sk)->num;

	addr->v4.sin_port = 0;

	addr->v4.sin_addr.s_addr = inet_sk(sk)->rcv_saddr;

}