Commit 7a9e7bd3 authored by Kieran Bingham's avatar Kieran Bingham Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: vsp1: Ensure pipeline locking in resume path 



The vsp1_pipeline_ready() and vsp1_pipeline_run() functions must be
called with the pipeline lock held, fix the resume code path.

Signed-off-by: default avatarKieran Bingham <kieran+renesas@bingham.xyz>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 34e77ed8

drivers/media/platform/vsp1/vsp1_pipe.c

+3 −0
Original line number Diff line number Diff line
@@ -365,6 +365,7 @@ void vsp1_pipelines_suspend(struct vsp1_device *vsp1) 


void vsp1_pipelines_resume(struct vsp1_device *vsp1)

{

	unsigned long flags;

	unsigned int i;



	/* Resume all running pipelines. */
@@ -379,7 +380,9 @@ void vsp1_pipelines_resume(struct vsp1_device *vsp1) 
		if (pipe == NULL)

			continue;



		spin_lock_irqsave(&pipe->irqlock, flags);

		if (vsp1_pipeline_ready(pipe))

			vsp1_pipeline_run(pipe);

		spin_unlock_irqrestore(&pipe->irqlock, flags);

	}

}