Commit 79d6e6e6 authored Jan 06, 2018 by Colin Ian King Committed by Mauro Carvalho Chehab Mar 06, 2018

media: exynos4-is: make array 'cmd' static, shrinks object size



Don't populate the const read-only array 'cmd' on the stack but instead
make it static. Makes the object code smaller by 38 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   4950	    868	      0	   5818	   16ba	fimc-is-regs.o

After:
   text	   data	    bss	    dec	    hex	filename
   4824	    956	      0	   5780	   1694	fimc-is-regs.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent c00ba2c1

drivers/media/platform/exynos4-is/fimc-is-regs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,7 @@ void fimc_is_hw_load_setfile(struct fimc_is *is)

		int fimc_is_hw_change_mode(struct fimc_is *is)
		{
		const u8 cmd[] = {
		static const u8 cmd[] = {
		HIC_PREVIEW_STILL, HIC_PREVIEW_VIDEO,
		HIC_CAPTURE_STILL, HIC_CAPTURE_VIDEO,
		};