Commit 7994aae8 authored Apr 22, 2020 by Kaixu Xia Committed by Darrick J. Wong May 04, 2020

xfs: remove unnecessary assertion from xfs_qm_vop_create_dqattach



The check XFS_IS_QUOTA_RUNNING() has been done when enter the
xfs_qm_vop_create_dqattach() function, it will return directly
if the result is false, so the followed XFS_IS_QUOTA_RUNNING()
assertion is unnecessary. If we truly care about this, the check
also can be added to the condition of next if statements.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent ea1c9040

fs/xfs/xfs_qm.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1932,7 +1932,6 @@ xfs_qm_vop_create_dqattach(
		return;

		ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
		ASSERT(XFS_IS_QUOTA_RUNNING(mp));

		if (udqp && XFS_IS_UQUOTA_ON(mp)) {
		ASSERT(ip->i_udquot == NULL);