Commit 77006a0a authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

ratelimit: add comment warning people off printk_ratelimit() 



printk_ratelimit() was a bad idea - we don't want subsytem A causing
ratelimiting of subsystem B's messages.

Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f5d87d85

include/linux/kernel.h

+5 −0
Original line number Diff line number Diff line
@@ -277,6 +277,11 @@ asmlinkage int vprintk(const char *fmt, va_list args) 
asmlinkage int printk(const char * fmt, ...)

	__attribute__ ((format (printf, 1, 2))) __cold;



/*

 * Please don't use printk_ratelimit(), because it shares ratelimiting state

 * with all other unrelated printk_ratelimit() callsites.  Instead use

 * printk_ratelimited() or plain old __ratelimit().

 */

extern int __printk_ratelimit(const char *func);

#define printk_ratelimit() __printk_ratelimit(__func__)

extern bool printk_timed_ratelimit(unsigned long *caller_jiffies,