Commit 767cd17a authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Linus Walleij
Browse files

gpiolib: Initialize gdev field before is used 



gpio_hog depends on gdev field being initialized. This patch fixes an
OOPs during initialization of TI's AM335x-ICEv2.

Fixes: 3edfb7bd ("gpiolib: Show correct direction from the beginning")
Tested-by: default avatarVignesh R <vigneshr@ti.com>
Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7a42781e

drivers/gpio/gpiolib.c

+3 −2
Original line number Diff line number Diff line
@@ -1351,6 +1351,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, 


	spin_unlock_irqrestore(&gpio_lock, flags);



	for (i = 0; i < chip->ngpio; i++)

		gdev->descs[i].gdev = gdev;



#ifdef CONFIG_PINCTRL

	INIT_LIST_HEAD(&gdev->pin_ranges);

#endif
@@ -1382,8 +1385,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, 
	for (i = 0; i < chip->ngpio; i++) {

		struct gpio_desc *desc = &gdev->descs[i];



		desc->gdev = gdev;



		if (chip->get_direction && gpiochip_line_is_valid(chip, i))

			desc->flags = !chip->get_direction(chip, i) ?

					(1 << FLAG_IS_OUT) : 0;