Commit 735c7064 authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/gmc11: don't touch gfxhub registers during S0ix 



gfxhub registers are part of gfx IP and should not need to be
changed.  Doing so without disabling gfxoff can hang the gfx IP.

v2: add comments explaining why we can skip the interrupt
    control for S0i3

Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d5d29009

drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c

+14 −2
Original line number Diff line number Diff line
@@ -64,12 +64,24 @@ gmc_v11_0_vm_fault_interrupt_state(struct amdgpu_device *adev, 
		/* MM HUB */

		amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_MMHUB_0, false);

		/* GFX HUB */

		/* This works because this interrupt is only

		 * enabled at init/resume and disabled in

		 * fini/suspend, so the overall state doesn't

		 * change over the course of suspend/resume.

		 */

		if (!adev->in_s0ix)

			amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_GFXHUB_0, false);

		break;

	case AMDGPU_IRQ_STATE_ENABLE:

		/* MM HUB */

		amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_MMHUB_0, true);

		/* GFX HUB */

		/* This works because this interrupt is only

		 * enabled at init/resume and disabled in

		 * fini/suspend, so the overall state doesn't

		 * change over the course of suspend/resume.

		 */

		if (!adev->in_s0ix)

			amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_GFXHUB_0, true);

		break;

	default: