Commit 6f17a044 authored by Fan Yong's avatar Fan Yong Committed by Greg Kroah-Hartman
Browse files

staging: lustre: acl: increase ACL entries limitation 



Originally, the limitation of ACL entries is 32, that is not
enough for some use cases. In fact, restricting ACL entries
count is mainly for preparing the RPC reply buffer to receive
the ACL data. So we cannot make the ACL entries count to be
unlimited. But we can enlarge the RPC reply buffer to hold
more ACL entries. On the other hand, MDT backend filesystem
has its own EA size limitation. For example, for ldiskfs case,
if large EA enable, then the max ACL size is 1048492 bytes;
otherwise, it is 4012 bytes. For ZFS backend, such value is
32768 bytes. With such hard limitation, we can calculate how
many ACL entries we can have at most. This patch increases
the RPC reply buffer to match such hard limitation. For old
client, to avoid buffer overflow because of large ACL data
(more than 32 ACL entries), the MDT will forbid the old client
to access the file with large ACL data. As for how to know
whether it is old client or new, a new connection flag
OBD_CONNECT_LARGE_ACL is used for that.

Signed-off-by: default avatarFan Yong <fan.yong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7473
Reviewed-on: https://review.whamcloud.com/19790


Reviewed-by: default avatarAndreas Dilger <andreas.dilger@intel.com>
Reviewed-by: default avatarLi Xi <lixi@ddn.com>
Reviewed-by: default avatarLai Siyao <lai.siyao@intel.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a694be44

drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h

+1 −1
Original line number Diff line number Diff line
@@ -615,7 +615,7 @@ struct ptlrpc_body_v2 { 
#define OBD_CONNECT_REQPORTAL		 0x40ULL /*Separate non-IO req portal */

#define OBD_CONNECT_ACL			 0x80ULL /*access control lists */

#define OBD_CONNECT_XATTR		0x100ULL /*client use extended attr */

#define OBD_CONNECT_CROW		0x200ULL /*MDS+OST create obj on write*/

#define OBD_CONNECT_LARGE_ACL		0x200ULL /* more than 32 ACL entries */

#define OBD_CONNECT_TRUNCLOCK		0x400ULL /*locks on server for punch */

#define OBD_CONNECT_TRANSNO		0x800ULL /*replay sends init transno */

#define OBD_CONNECT_IBITS	       0x1000ULL /*support for inodebits locks*/

drivers/staging/lustre/lustre/include/lustre_acl.h

+6 −1
Original line number Diff line number Diff line
@@ -36,11 +36,16 @@ 


#include <linux/fs.h>

#include <linux/dcache.h>

#ifdef CONFIG_FS_POSIX_ACL

#include <linux/posix_acl_xattr.h>



#define LUSTRE_POSIX_ACL_MAX_ENTRIES	32

#define LUSTRE_POSIX_ACL_MAX_SIZE						\

#define LUSTRE_POSIX_ACL_MAX_SIZE_OLD						\

	(sizeof(struct posix_acl_xattr_header) +				\

	 LUSTRE_POSIX_ACL_MAX_ENTRIES * sizeof(struct posix_acl_xattr_entry))



#else /* ! CONFIG_FS_POSIX_ACL */

#define LUSTRE_POSIX_ACL_MAX_SIZE_OLD 0

#endif /* CONFIG_FS_POSIX_ACL */



#endif

drivers/staging/lustre/lustre/llite/llite_lib.c

+2 −1
Original line number Diff line number Diff line
@@ -199,7 +199,8 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt) 
	if (sbi->ll_flags & LL_SBI_LRU_RESIZE)

		data->ocd_connect_flags |= OBD_CONNECT_LRU_RESIZE;

#ifdef CONFIG_FS_POSIX_ACL

	data->ocd_connect_flags |= OBD_CONNECT_ACL | OBD_CONNECT_UMASK;

	data->ocd_connect_flags |= OBD_CONNECT_ACL | OBD_CONNECT_UMASK |

				   OBD_CONNECT_LARGE_ACL;

#endif



	if (OBD_FAIL_CHECK(OBD_FAIL_MDC_LIGHTWEIGHT))

drivers/staging/lustre/lustre/mdc/mdc_locks.c

+6 −0
Original line number Diff line number Diff line
@@ -308,6 +308,8 @@ mdc_intent_open_pack(struct obd_export *exp, struct lookup_intent *it, 


	req_capsule_set_size(&req->rq_pill, &RMF_MDT_MD, RCL_SERVER,

			     obddev->u.cli.cl_max_mds_easize);

	req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER,

			     req->rq_import->imp_connect_data.ocd_max_easize);



	ptlrpc_request_set_replen(req);

	return req;
@@ -352,6 +354,8 @@ mdc_intent_getxattr_pack(struct obd_export *exp, 
	req_capsule_set_size(&req->rq_pill, &RMF_EAVALS_LENS,

			     RCL_SERVER, maxdata);



	req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER, maxdata);



	ptlrpc_request_set_replen(req);



	return req;
@@ -433,6 +437,8 @@ static struct ptlrpc_request *mdc_intent_getattr_pack(struct obd_export *exp, 
	mdc_getattr_pack(req, valid, it->it_flags, op_data, easize);



	req_capsule_set_size(&req->rq_pill, &RMF_MDT_MD, RCL_SERVER, easize);

	req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER,

			     req->rq_import->imp_connect_data.ocd_max_easize);

	ptlrpc_request_set_replen(req);

	return req;

}

drivers/staging/lustre/lustre/mdc/mdc_reint.c

+2 −0
Original line number Diff line number Diff line
@@ -134,6 +134,8 @@ int mdc_setattr(struct obd_export *exp, struct md_op_data *op_data, 
		       LTIME_S(op_data->op_attr.ia_ctime));

	mdc_setattr_pack(req, op_data, ea, ealen);



	req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER,

			     req->rq_import->imp_connect_data.ocd_max_easize);

	ptlrpc_request_set_replen(req);



	rc = mdc_reint(req, LUSTRE_IMP_FULL);