Commit 6e70b73c authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

tty: moxa: fix TIOCSSERIAL jiffies conversions 



The port close_delay parameter set by TIOCSSERIAL is specified in
jiffies, while the value returned by TIOCGSERIAL is specified in
centiseconds.

Add the missing conversions so that TIOCGSERIAL works as expected also
when HZ is not 100.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210407102334.32361-11-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c33a63e8

drivers/tty/moxa.c

+2 −2
Original line number Diff line number Diff line
@@ -2038,7 +2038,7 @@ static int moxa_get_serial_info(struct tty_struct *tty, 
	ss->line = info->port.tty->index,

	ss->flags = info->port.flags,

	ss->baud_base = 921600,

	ss->close_delay = info->port.close_delay;

	ss->close_delay = jiffies_to_msecs(info->port.close_delay) / 10;

	mutex_unlock(&info->port.mutex);

	return 0;

}
@@ -2067,7 +2067,7 @@ static int moxa_set_serial_info(struct tty_struct *tty, 
			return -EPERM;

		}

	}

	info->port.close_delay = ss->close_delay * HZ / 100;

	info->port.close_delay = msecs_to_jiffies(ss->close_delay * 10);



	MoxaSetFifo(info, ss->type == PORT_16550A);