Commit 6d58ef05 authored Aug 08, 2019 by Bart Van Assche Committed by Martin K. Petersen Aug 12, 2019

scsi: qla2xxx: Reduce the scope of three local variables in qla2xxx_queuecommand()



This patch makes it clear that the tag, hwq and qpair variables are only
used in the mq path.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 909c1d14

drivers/scsi/qla2xxx/qla_os.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -845,9 +845,6 @@ qla2xxx_queuecommand(struct Scsi_Host host, struct scsi_cmnd cmd)
		struct scsi_qla_host *base_vha = pci_get_drvdata(ha->pdev);
		srb_t *sp;
		int rval;
		struct qla_qpair *qpair = NULL;
		uint32_t tag;
		uint16_t hwq;

		if (unlikely(test_bit(UNLOADING, &base_vha->dpc_flags)) \|\|
		WARN_ON_ONCE(!rport)) {
		@@ -856,6 +853,10 @@ qla2xxx_queuecommand(struct Scsi_Host host, struct scsi_cmnd cmd)
		}

		if (ha->mqenable) {
		uint32_t tag;
		uint16_t hwq;
		struct qla_qpair *qpair = NULL;

		tag = blk_mq_unique_tag(cmd->request);
		hwq = blk_mq_unique_tag_to_hwq(tag);
		qpair = ha->queue_pair_map[hwq];