Commit 6c411581 authored by Ajay Singh's avatar Ajay Singh Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: avoid double unlocking of 'wilc->hif_cs' mutex 

Possible double unlocking of 'wilc->hif_cs' mutex was identified by
smatch [1]. Removed the extra call to release_bus() in
wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1a
("staging: wilc1000: support suspend/resume functionality").

[1]. https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/NOEVW7C3GV74EWXJO3XX6VT2NKVB2HMT/



Reported-by: default avatarkbuild test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Link: https://lore.kernel.org/r/20200221170120.15739-1-ajay.kathat@microchip.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 007b9143

drivers/staging/wilc1000/wlan.c

+0 −1
Original line number Diff line number Diff line
@@ -575,7 +575,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count) 
				entries = FIELD_GET(WILC_VMM_ENTRY_COUNT, reg);

				break;

			}

			release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);

		} while (--timeout);

		if (timeout <= 0) {

			ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x0);