Commit 6b92e435 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Kalle Valo
Browse files

wifi: atmel: Fix an error handling path in atmel_probe() 



Should atmel_config() fail, some resources need to be released as already
done in the remove function.

While at it, remove a useless and erroneous comment. The probe is
atmel_probe(), not atmel_attach().

Fixes: 15b99ac1 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1e65f174607a83348034197fa7d603bab10ba4a9.1684569156.git.christophe.jaillet@wanadoo.fr
parent 67a81d91

drivers/net/wireless/atmel/atmel_cs.c

+11 −2
Original line number Diff line number Diff line
@@ -72,6 +72,7 @@ struct local_info { 
static int atmel_probe(struct pcmcia_device *p_dev)

{

	struct local_info *local;

	int ret;



	dev_dbg(&p_dev->dev, "atmel_attach()\n");
@@ -82,8 +83,16 @@ static int atmel_probe(struct pcmcia_device *p_dev) 


	p_dev->priv = local;



	return atmel_config(p_dev);

} /* atmel_attach */

	ret = atmel_config(p_dev);

	if (ret)

		goto err_free_priv;



	return 0;



err_free_priv:

	kfree(p_dev->priv);

	return ret;

}



static void atmel_detach(struct pcmcia_device *link)

{