Commit 6b1b60f4 authored by Don Mullis's avatar Don Mullis Committed by Linus Torvalds
Browse files

[PATCH] fault-injection: defaults likely to please a new user 



Assign defaults most likely to please a new user:
 1) generate some logging output
    (verbose=2)
 2) avoid injecting failures likely to lock up UI
    (ignore_gfp_wait=1, ignore_gfp_highmem=1)

Signed-off-by: default avatarDon Mullis <dwm@meer.net>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent f1729c28

include/linux/fault-inject.h

+1 −0
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ struct fault_attr { 
		.times = ATOMIC_INIT(1),			\

		.require_end = ULONG_MAX,			\

		.stacktrace_depth = 32,				\

		.verbose = 2,					\

	}



#define DECLARE_FAULT_ATTR(name) struct fault_attr name = FAULT_ATTR_INITIALIZER

mm/page_alloc.c

+2 −0
Original line number Diff line number Diff line
@@ -910,6 +910,8 @@ static struct fail_page_alloc_attr { 


} fail_page_alloc = {

	.attr = FAULT_ATTR_INITIALIZER,

	.ignore_gfp_wait = 1,

	.ignore_gfp_highmem = 1,

};



static int __init setup_fail_page_alloc(char *str)

mm/slab.c

+1 −0
Original line number Diff line number Diff line
@@ -3102,6 +3102,7 @@ static struct failslab_attr { 


} failslab = {

	.attr = FAULT_ATTR_INITIALIZER,

	.ignore_gfp_wait = 1,

};



static int __init setup_failslab(char *str)