Commit 67db05ce authored by Lee Jones's avatar Lee Jones Committed by Greg Kroah-Hartman
Browse files

misc: habanalabs: goya: goya_coresight: Remove set but unused variable 'val' 



No attempt to check the return value of RREG32() has been made
since the call was introduced a year ago.

Fixes W=1 kernel build warning:

 drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’:
 drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable]
 643 | u32 val;
 | ^~~

Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: Tomer Tayar <ttayar@habana.ai>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Reviewed-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Link: https://lore.kernel.org/r/20200701085853.164358-9-lee.jones@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0712c60

drivers/misc/habanalabs/goya/goya_coresight.c

+1 −2
Original line number Diff line number Diff line
@@ -640,7 +640,6 @@ static int goya_config_spmu(struct hl_device *hdev, 
int goya_debug_coresight(struct hl_device *hdev, void *data)

{

	struct hl_debug_params *params = data;

	u32 val;

	int rc = 0;



	switch (params->op) {
@@ -672,7 +671,7 @@ int goya_debug_coresight(struct hl_device *hdev, void *data) 
	}



	/* Perform read from the device to flush all configuration */

	val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG);

	RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG);



	return rc;

}