Commit 67c9e830 authored by Raag Jadav's avatar Raag Jadav Committed by Andy Shevchenko
Browse files

pinctrl: lynxpoint: drop runtime PM support 



Since Lynxpoint pinctrl device is not attached to acpi_lpss_pm_domain,
runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr()
as now we only have resume handle in place.

Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20231003114036.27674-3-raag.jadav@intel.com


Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 8fd51616

drivers/pinctrl/intel/pinctrl-lynxpoint.c

+3 −29
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/platform_device.h>

#include <linux/pm_runtime.h>

#include <linux/pm.h>

#include <linux/seq_file.h>

#include <linux/slab.h>

#include <linux/types.h>
@@ -337,8 +337,6 @@ static int lp_gpio_request_enable(struct pinctrl_dev *pctldev, 
	unsigned long flags;

	u32 value;



	pm_runtime_get(lg->dev);



	raw_spin_lock_irqsave(&lg->lock, flags);



	/*
@@ -373,8 +371,6 @@ static void lp_gpio_disable_free(struct pinctrl_dev *pctldev, 
	lp_gpio_disable_input(conf2);



	raw_spin_unlock_irqrestore(&lg->lock, flags);



	pm_runtime_put(lg->dev);

}



static int lp_gpio_set_direction(struct pinctrl_dev *pctldev,
@@ -841,24 +837,6 @@ static int lp_gpio_probe(struct platform_device *pdev) 
		return ret;

	}



	pm_runtime_enable(dev);



	return 0;

}



static int lp_gpio_remove(struct platform_device *pdev)

{

	pm_runtime_disable(&pdev->dev);

	return 0;

}



static int lp_gpio_runtime_suspend(struct device *dev)

{

	return 0;

}



static int lp_gpio_runtime_resume(struct device *dev)

{

	return 0;

}
@@ -876,10 +854,7 @@ static int lp_gpio_resume(struct device *dev) 
	return 0;

}



static const struct dev_pm_ops lp_gpio_pm_ops = {

	SYSTEM_SLEEP_PM_OPS(NULL, lp_gpio_resume)

	RUNTIME_PM_OPS(lp_gpio_runtime_suspend, lp_gpio_runtime_resume, NULL)

};

static DEFINE_SIMPLE_DEV_PM_OPS(lp_gpio_pm_ops, NULL, lp_gpio_resume);



static const struct acpi_device_id lynxpoint_gpio_acpi_match[] = {

	{ "INT33C7", (kernel_ulong_t)&lptlp_soc_data },
@@ -890,10 +865,9 @@ MODULE_DEVICE_TABLE(acpi, lynxpoint_gpio_acpi_match); 


static struct platform_driver lp_gpio_driver = {

	.probe          = lp_gpio_probe,

	.remove         = lp_gpio_remove,

	.driver         = {

		.name   = "lp_gpio",

		.pm	= pm_ptr(&lp_gpio_pm_ops),

		.pm	= pm_sleep_ptr(&lp_gpio_pm_ops),

		.acpi_match_table = lynxpoint_gpio_acpi_match,

	},

};