Commit 66f8a4a0 authored by Justin Stitt's avatar Justin Stitt Committed by Kees Cook
Browse files

hwmon: (ibmpowernv) Replace deprecated strncpy() with memcpy() 

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

A suitable replacement is `memcpy` as we've already precisely calculated
the number of bytes to copy while `buf` has been explicitly
zero-initialized:
| 	char buf[8] = { 0 };

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90


Cc: linux-hardening@vger.kernel.org
Signed-off-by: default avatarJustin Stitt <justinstitt@google.com>
Tested-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Acked-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com


Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent abe6db6c

drivers/hwmon/ibmpowernv.c

+1 −1
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr) 
	if (copy_len >= sizeof(buf))

		return -EINVAL;



	strncpy(buf, hash_pos + 1, copy_len);

	memcpy(buf, hash_pos + 1, copy_len);



	err = kstrtou32(buf, 10, index);

	if (err)