Commit 6606f4c3 authored by Logan Gunthorpe's avatar Logan Gunthorpe Committed by Bjorn Helgaas
Browse files

PCI/P2PDMA: Annotate RCU dereference 

A dereference of the __rcu pointer was noticed by sparse:

  drivers/pci/p2pdma.c:199:44: sparse: sparse: dereference of noderef expression

Dereference the __rcu pointer using rcu_dereference_protected() instead of
accessing it directly. It's safe to use rcu_dereference_protected() because
a reference is held on the pgmap's percpu reference counter and thus it
cannot disappear.

Link: https://lore.kernel.org/r/20230209172953.4597-1-logang@deltatee.com


Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
parent 1b929c02

drivers/pci/p2pdma.c

+5 −3
Original line number Diff line number Diff line
@@ -194,11 +194,13 @@ static const struct attribute_group p2pmem_group = { 
static void p2pdma_page_free(struct page *page)

{

	struct pci_p2pdma_pagemap *pgmap = to_p2p_pgmap(page->pgmap);

	/* safe to dereference while a reference is held to the percpu ref */

	struct pci_p2pdma *p2pdma =

		rcu_dereference_protected(pgmap->provider->p2pdma, 1);

	struct percpu_ref *ref;



	gen_pool_free_owner(pgmap->provider->p2pdma->pool,

			    (uintptr_t)page_to_virt(page), PAGE_SIZE,

			    (void **)&ref);

	gen_pool_free_owner(p2pdma->pool, (uintptr_t)page_to_virt(page),

			    PAGE_SIZE, (void **)&ref);

	percpu_ref_put(ref);

}