Commit 65f8db81 authored by Colin Ian King's avatar Colin Ian King Committed by Alex Deucher
Browse files

drm/amdkfd: fix uint32 variable compared to less than zero 



Currently the call to kfd_process_gpuidx_from_gpuid is returning an
int value and this is being assigned to a uint32_t variable gpuidx
and this is being checked for a negative error return which is always
going to be false. Fix this by making gpuidx an int32_t. This makes
gpuidx also type consistent with the use of gpuidx from the callers.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: cda0f85b ("drm/amdkfd: refine migration policy with xnack on")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 63f1af83

drivers/gpu/drm/amd/amdkfd/kfd_svm.c

+1 −1
Original line number Diff line number Diff line
@@ -1330,7 +1330,7 @@ static void svm_range_unreserve_bos(struct svm_validate_context *ctx) 
 */

static int svm_range_validate_and_map(struct mm_struct *mm,

				      struct svm_range *prange,

				      uint32_t gpuidx, bool intr, bool wait)

				      int32_t gpuidx, bool intr, bool wait)

{

	struct svm_validate_context ctx;

	struct hmm_range *hmm_range;