Commit 60de1a67 authored by Igor Pylypiv's avatar Igor Pylypiv Committed by Martin K. Petersen
Browse files

scsi: pm80xx: Do not check the address-of value for NULL 

Address-of operator cannot return NULL.

Link: https://lore.kernel.org/r/20211101232825.2350233-3-ipylypiv@google.com


Reviewed-by: default avatarVishakha Channapattan <vishakhavc@google.com>
Acked-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarIgor Pylypiv <ipylypiv@google.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 744798fc

drivers/scsi/pm8001/pm8001_hwi.c

+4 −20
Original line number Diff line number Diff line
@@ -2304,21 +2304,17 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) 


	psataPayload = (struct sata_completion_resp *)(piomb + 4);

	status = le32_to_cpu(psataPayload->status);

	param = le32_to_cpu(psataPayload->param);

	tag = le32_to_cpu(psataPayload->tag);



	if (!tag) {

		pm8001_dbg(pm8001_ha, FAIL, "tag null\n");

		return;

	}



	ccb = &pm8001_ha->ccb_info[tag];

	param = le32_to_cpu(psataPayload->param);

	if (ccb) {

	t = ccb->task;

	pm8001_dev = ccb->device;

	} else {

		pm8001_dbg(pm8001_ha, FAIL, "ccb null\n");

		return;

	}



	if (t) {

		if (t->dev && (t->dev->lldd_dev))
@@ -2335,10 +2331,6 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb) 
	}



	ts = &t->task_status;

	if (!ts) {

		pm8001_dbg(pm8001_ha, FAIL, "ts null\n");

		return;

	}



	if (status)

		pm8001_dbg(pm8001_ha, IOERR,
@@ -2695,14 +2687,6 @@ static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha, void *piomb) 
	u32 dev_id = le32_to_cpu(psataPayload->device_id);

	unsigned long flags;



	ccb = &pm8001_ha->ccb_info[tag];



	if (ccb) {

		t = ccb->task;

		pm8001_dev = ccb->device;

	} else {

		pm8001_dbg(pm8001_ha, FAIL, "No CCB !!!. returning\n");

	}

	if (event)

		pm8001_dbg(pm8001_ha, FAIL, "SATA EVENT 0x%x\n", event);

drivers/scsi/pm8001/pm80xx_hwi.c

+8 −21
Original line number Diff line number Diff line
@@ -2400,21 +2400,17 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, 


	psataPayload = (struct sata_completion_resp *)(piomb + 4);

	status = le32_to_cpu(psataPayload->status);

	param = le32_to_cpu(psataPayload->param);

	tag = le32_to_cpu(psataPayload->tag);



	if (!tag) {

		pm8001_dbg(pm8001_ha, FAIL, "tag null\n");

		return;

	}



	ccb = &pm8001_ha->ccb_info[tag];

	param = le32_to_cpu(psataPayload->param);

	if (ccb) {

	t = ccb->task;

	pm8001_dev = ccb->device;

	} else {

		pm8001_dbg(pm8001_ha, FAIL, "ccb null\n");

		return;

	}



	if (t) {

		if (t->dev && (t->dev->lldd_dev))
@@ -2431,10 +2427,6 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, 
	}



	ts = &t->task_status;

	if (!ts) {

		pm8001_dbg(pm8001_ha, FAIL, "ts null\n");

		return;

	}



	if (status != IO_SUCCESS) {

		pm8001_dbg(pm8001_ha, FAIL,
@@ -2830,15 +2822,6 @@ static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha, 
	u32 dev_id = le32_to_cpu(psataPayload->device_id);

	unsigned long flags;



	ccb = &pm8001_ha->ccb_info[tag];



	if (ccb) {

		t = ccb->task;

		pm8001_dev = ccb->device;

	} else {

		pm8001_dbg(pm8001_ha, FAIL, "No CCB !!!. returning\n");

		return;

	}

	if (event)

		pm8001_dbg(pm8001_ha, FAIL, "SATA EVENT 0x%x\n", event);
@@ -2852,6 +2835,10 @@ static void mpi_sata_event(struct pm8001_hba_info *pm8001_ha, 
		return;

	}



	ccb = &pm8001_ha->ccb_info[tag];

	t = ccb->task;

	pm8001_dev = ccb->device;



	if (unlikely(!t || !t->lldd_task || !t->dev)) {

		pm8001_dbg(pm8001_ha, FAIL, "task or dev null\n");

		return;