Commit 5f9ae9ee authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ib_srp: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-6-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 409d337e

drivers/infiniband/ulp/srp/ib_srp.c

+4 −4
Original line number Diff line number Diff line
@@ -1266,7 +1266,7 @@ static void srp_finish_req(struct srp_rdma_ch *ch, struct srp_request *req, 
	if (scmnd) {

		srp_free_req(ch, req, scmnd, 0);

		scmnd->result = result;

		scmnd->scsi_done(scmnd);

		scsi_done(scmnd);

	}

}
@@ -1987,7 +1987,7 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp) 
		srp_free_req(ch, req, scmnd,

			     be32_to_cpu(rsp->req_lim_delta));



		scmnd->scsi_done(scmnd);

		scsi_done(scmnd);

	}

}
@@ -2239,7 +2239,7 @@ static int srp_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmnd) 


err:

	if (scmnd->result) {

		scmnd->scsi_done(scmnd);

		scsi_done(scmnd);

		ret = 0;

	} else {

		ret = SCSI_MLQUEUE_HOST_BUSY;
@@ -2811,7 +2811,7 @@ static int srp_abort(struct scsi_cmnd *scmnd) 
	if (ret == SUCCESS) {

		srp_free_req(ch, req, scmnd, 0);

		scmnd->result = DID_ABORT << 16;

		scmnd->scsi_done(scmnd);

		scsi_done(scmnd);

	}



	return ret;