Commit 5f6ac2ce authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: bfa: Do not dereference port before it is null checked 



Port is deferenced before it is null sanity checked, hence we
potentially have a null pointer dereference bug. Instead, initialise
trl_enabled from port->fcs->bfa after we are sure port is not null.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 02ccda2a

drivers/scsi/bfa/bfa_fcs_lport.c

+2 −2
Original line number Diff line number Diff line
@@ -5827,13 +5827,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port) 
	bfa_port_speed_t max_speed = 0;

	struct bfa_port_attr_s port_attr;

	bfa_port_speed_t port_speed, rport_speed;

	bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);



	bfa_boolean_t trl_enabled;



	if (port == NULL)

		return 0;



	fcs = port->fcs;

	trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);



	/* Get Physical port's current speed */

	bfa_fcport_get_attr(port->fcs->bfa, &port_attr);